[newlib-cygwin/main] Cygwin: fix gcc-14 false positive warnings
Corinna Vinschen
corinna@sourceware.org
Thu Feb 27 12:17:45 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=dc094c76657c2632196d3d67476a6c783ed0c285
commit dc094c76657c2632196d3d67476a6c783ed0c285
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Thu Feb 27 12:17:23 2025 +0100
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Thu Feb 27 12:17:23 2025 +0100
Cygwin: fix gcc-14 false positive warnings
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/sec/acl.cc | 2 +-
winsup/cygwin/uname.cc | 8 +++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/winsup/cygwin/sec/acl.cc b/winsup/cygwin/sec/acl.cc
index b92f62493e1e..fa4ea4ceeede 100644
--- a/winsup/cygwin/sec/acl.cc
+++ b/winsup/cygwin/sec/acl.cc
@@ -665,7 +665,7 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
mode_t attr = 0;
aclent_t *lacl = NULL;
cygpsid ace_sid, *aclsid;
- int pos, type, idx;
+ int pos = 0, type, idx;
id_t id;
bool owner_eq_group;
diff --git a/winsup/cygwin/uname.cc b/winsup/cygwin/uname.cc
index 52c807ae54aa..c08e30f97da9 100644
--- a/winsup/cygwin/uname.cc
+++ b/winsup/cygwin/uname.cc
@@ -32,7 +32,7 @@ uname_x (struct utsname *name)
{
__try
{
- char buf[NI_MAXHOST + 1] ATTRIBUTE_NONSTRING;
+ char buf[NI_MAXHOST + 1];
int n;
memset (name, 0, sizeof (*name));
@@ -55,7 +55,8 @@ uname_x (struct utsname *name)
/* nodename */
memset (buf, 0, sizeof buf);
cygwin_gethostname (buf, sizeof buf - 1);
- strncat (name->nodename, buf, sizeof (name->nodename) - 1);
+ buf[sizeof (name->nodename) - 1] = '\0';
+ strcpy (name->nodename, buf);
/* machine */
switch (wincap.cpu_arch ())
{
@@ -92,7 +93,8 @@ uname_x (struct utsname *name)
/* domainame */
memset (buf, 0, sizeof buf);
getdomainname (buf, sizeof buf - 1);
- strncat (name->domainname, buf, sizeof (name->domainname) - 1);
+ buf[sizeof (name->domainname) - 1] = '\0';
+ strcpy (name->domainname, buf);
}
__except (EFAULT) { return -1; }
__endtry
More information about the Cygwin-cvs
mailing list