-f option to mount no longer works?

Kazuhiro Fujieda fujieda@jaist.ac.jp
Tue Jun 13 09:29:00 GMT 2000


>>> On Sat, 10 Jun 2000 17:48:12 -0400
>>> Chris Faylor <cgf@cygnus.com> said:

> I have just noticed that when I attempt to remount the root partition with
> a 'mount -f -b f:\cygwin /' it fails with a
> 
> mount: /: Too many mount entries
> 
> I don't have too many mount entries, of course.
> 
> Is this the result of Kazuhiro Fujieda's recent changes, maybe?

Yes, this is triggered by a simple mistake.

ChangeLog:
	path.cc (mount_info::add_item): The previous patch can't handle
	the case of overwriting a mount entry.

Index: path.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/path.cc,v
retrieving revision 1.29
diff -u -p -r1.29 path.cc
--- path.cc	2000/06/13 04:40:36	1.29
+++ path.cc	2000/06/13 16:22:31
@@ -1645,13 +1645,15 @@ mount_info::add_item (const char *native
 	break;
     }
 
-  /* Can't add more than MAX_MOUNTS. */
-  if (i == nmounts && nmounts < MAX_MOUNTS)
-    i = nmounts++;
-  else
+  if (i == nmounts)
     {
-      set_errno (EMFILE);
-      return -1;
+      if (nmounts < MAX_MOUNTS)
+	i = nmounts++;
+      else
+	{
+	  set_errno (EMFILE);
+	  return -1;
+	}
     }
 
   if (reg_p && add_reg_mount (nativetmp, posixtmp, mountflags))

____
  | AIST      Kazuhiro Fujieda <fujieda@jaist.ac.jp>
  | HOKURIKU  School of Information Science
o_/ 1990      Japan Advanced Institute of Science and Technology


More information about the Cygwin-developers mailing list