Corinna or Pierre please comment? [jason@tishler.net: Re: setuid() problem when disconnected from PDC under 1.3.12-2]

[Pierre A. Humblet]

Corinna Vinschen wrote:

> What do you mean?  A debug output when NetGetDCName() fails is already
> in the code and when get_user_groups() fails, too.  What does an extra
> system_printf help?

The debug output is only visible with strace. Somehow I would like to convey 
to unsophisticated users that they should edit /etc/group if they have 
a permission problem when running disconnected. That should be written
in some doc...
 
> Could you just hand in the ChangeLog?  I will apply the patch ASAP then.

That will be for tonight. There will be a slightly improved patch, 
avoiding duplicate groups.

By the way, 
   struct __group32 *gr;
   if (gr->gr_gid == pw->pw_gid)
 causes a compiler warning about signed/unsigned comparison.
 struct passwd has an "int pw_gid" field. Is that posix?
 
I am also working on a setgroup().

Pierre