Should sys/types.h include sys/sysmacros.h?

[Corinna Vinschen]

On Tue, May 21, 2002 at 04:46:40PM -0400, Gerald S. Williams wrote:
> Jason Tishler wrote:
> > Actually, I just determined that sys/types.h includes cygwin/types.h.
> > So, should I include sys/sysmacros.h in cygwin/types.h instead?
> 
> But cygwin/types.h includes sys/sysmacros.h already. I think
> the problem is that sys/types.h isn't always including
> cygwin/types.h. A closer look reveals that it doesn't do this
> if _POSIX_THREADS is defined.

That statement isn't correct.  cygwin/types.h is included

  if !_POSIX_THREADS || __CYGWIN__

so it's always included when building under Cygwin.

[...]
On Wed, May 22, 2002 at 01:39:09PM +0200, Corinna Vinschen wrote:
> I've checked in two patches which should solve that problem.
> newlib/libc/include/sys/types.h includes <cygwin/types.h>
> now always if __CYGWIN__ is defined and cygwin/types.h defines
> the pthread stuff now only if _POSIX_THREADS is defined.
> So sys/sysmacros.h is now included (more or less) unconditionally
> and especially the uid16/32_t etc. types are defined, too.

Ok, this didn't work.  I reverted the patch to newlib and cygwin/types.h.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.