Recent security improvements breaks proftpd

Jason Tishler jason@tishler.net
Thu Sep 18 13:03:00 GMT 2003


Pierre,

The following change breaks proftpd:

    http://cygwin.com/ml/cygwin-cvs/2003-q3/msg00237.html

By "breaks", I mean the following failure occurs when a user attempts
to authenticate:

    C:\Cygwin\usr\sbin\proftpd.exe: *** CreateFileMapping, Win32 error 5.  Terminating.

I was able to workaround and isolate the problem with the attached
"patch" -- that is reverting to the old behavior.

Any ideas on how to fix the problem correctly?

Thanks,
Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6
-------------- next part --------------
Index: shared.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/shared.cc,v
retrieving revision 1.73
diff -u -p -r1.73 shared.cc
--- shared.cc	11 Sep 2003 07:57:39 -0000	1.73
+++ shared.cc	18 Sep 2003 12:51:59 -0000
@@ -97,7 +97,7 @@ open_shared (const char *name, int n, HA
 				       TRUE, mapname);
 	}
       if (!shared_h &&
-	  !(shared_h = CreateFileMapping (INVALID_HANDLE_VALUE, psa,
+	  !(shared_h = CreateFileMapping (INVALID_HANDLE_VALUE, &sec_all,
 					  PAGE_READWRITE, 0, size, mapname)))
 	api_fatal ("CreateFileMapping, %E.  Terminating.");
     }


More information about the Cygwin-developers mailing list