problem adding complex to newlib/cygwin

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Oct 5 08:32:00 GMT 2010


On Oct  4 21:16, Marco Atzeri wrote:
> Hi Corinna,
> I re-uploaded the patch to add the complex to newlib
> and cygwin on
> 
> http://matzeri.altervista.org/works/complex/
> 
> As suggested the code is taken from netbsd.
> No changelog yet, and eventually some code cleaning
> is needed, however it seems to work.
> [...]
> Could you review and let me know ho to proceed for the
> implementation ?

That looks good.  I would just prefer if you would drop the namespace.h
file and the corresponding #include statements entirely.

Proceeding is easy.  Just send the newlib part of the patch including a
ChangeLog to the newlib mailing list.  As soon as it has been
approved(*), send the cygwin.din patch and a matching ChangeLog entry to
the cygwin-patches list.  It's a non-brainer so we can do this without a
copyright assignment(*).


Thanks,
Corinna


(*) Of course, if you would like to sign a copyright assignment per
    http://cygwin.com/contrib.html to participate in Cygwin development,
    I certainly wouldn't reject it ;)

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat



More information about the Cygwin-developers mailing list