Rewriting the FIFO code

[Ken Brown]

On 12/26/2018 2:03 PM, Corinna Vinschen wrote:
> On Dec 26 14:00, Ken Brown wrote:
>> Thanks for the encouragement, and Happy Holidays to you too.  One question: In
>> the new AF_UNIX socket code you mostly used NT functions, but the existing FIFO
>> code uses Win32 functions.  Do you prefer NT functions for new code?
> 
> The NT functions have some advantages over the Win32 functions.
> For instance, WaitNamedPipe is not interruptible, while
> NtFsControlFile(FSCTL_PIPE_WAIT) can be called asynchronously
> and then you can just wait for an event object via cygwait
> (see fhandler_socket_unix::wait_pipe_thread).
> 
> So, in theory I'd prefer NT functions, but if you feel uncomfortable
> and just want to implement away, feel free to go ahead with Win32
> functions.

I've decided to use Win32 functions for now, not because of discomfort but 
because it allowed me to use more of the existing code.  I can always change 
that later.

I've got enough working now that I think my patches could use some review.  But 
there's still a lot more to do.  I've attached the patches, but I could send 
them to cygwin-patches instead if you prefer.

Ken
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0000-cover-letter.patch
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20190122/818979bc/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Cygwin-fhandler_fifo-allow-unlimited-pipe_instances.patch
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20190122/818979bc/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Cygwin-fhandler_fifo-Allow-multiple-writers.patch
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20190122/818979bc/attachment-0002.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Cygwin-adapt-fhandler_fifo-close-to-recent-changes.patch
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20190122/818979bc/attachment-0003.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Cygwin-fhandler_fifo-add-a-spinlock.patch
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20190122/818979bc/attachment-0004.ksh>