bugs in path_conv::update_fs_info.

Christopher Faylor cgf@redhat.com
Sun Jun 10 20:50:00 GMT 2001

On Sun, Jun 10, 2001 at 11:31:46PM -0400, Christopher Faylor wrote:
>On Fri, Jun 08, 2001 at 03:15:18AM +0900, Kazuhiro Fujieda wrote:
>>There are trivial mistakes in path_conv::update_fs_info.
>>It can't handle the case where GetCurrentDirectory will fail,
>>and invokes GetDriveType with an invalid argument.
>Gah!  We're calling GetCurrentDirectory?  I missed that.  What's the
>rationale for this?  The previous code didn't have this.  This looks
>like YA path_conv slowdown. (These observations are for Egor)
>I'd rather just nuke all of this GetCurrentDirectory logic.  I don't
>see how it makes sense to use the current directory in this context,

Which I've done.  I've also incorporated the "Set root_dir before
invoking GetDriveType." part of this patch.


More information about the Cygwin-patches mailing list