yet another "pedantic" patch

egor duda
Sat Sep 15 12:56:00 GMT 2001


Saturday, 15 September, 2001 Christopher Faylor wrote:

CF> It looks ok except for this:

CF> +  if (check_null_empty_str (topath) == EFAULT)
CF> +    {
CF> +      set_errno (EFAULT);
CF> +      goto done;
CF> +    }
CF> +  if (check_null_empty_str_errno (frompath))
CF> +    goto done;

CF> There is no reason for this duplication is there?  Can't this just be
CF> check_null_empty_str_errno?

ah, right. i was thinking for some reason that check_null_empty_str_errno()
returns true/false.

Egor.   ICQ 5165414 FidoNet 2:5020/496.19

-------------- next part --------------
2001-09-14  Egor Duda  <>

	* (symlink): Check arguments for validity.
	(getcwd): Ditto.
	* (ftruncate): Ditto.
	* (times): Ditto.
	* (uname): Ditto.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-args-validity-3.diff
Type: text/x-diff
Size: 3152 bytes
Desc: not available
URL: <>

More information about the Cygwin-patches mailing list