yet another "pedantic" patch
egor duda
deo@logos-m.ru
Sat Sep 15 12:56:00 GMT 2001
Hi!
Saturday, 15 September, 2001 Christopher Faylor cgf@redhat.com wrote:
CF> It looks ok except for this:
CF> + if (check_null_empty_str (topath) == EFAULT)
CF> + {
CF> + set_errno (EFAULT);
CF> + goto done;
CF> + }
CF> + if (check_null_empty_str_errno (frompath))
CF> + goto done;
CF> There is no reason for this duplication is there? Can't this just be
CF> check_null_empty_str_errno?
ah, right. i was thinking for some reason that check_null_empty_str_errno()
returns true/false.
Egor. mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19
check-args-validity-3.diff
check-args-validity-3.ChangeLog
-------------- next part --------------
2001-09-14 Egor Duda <deo@logos-m.ru>
* path.cc (symlink): Check arguments for validity.
(getcwd): Ditto.
* syscalls.cc (ftruncate): Ditto.
* times.cc (times): Ditto.
* uname.cc (uname): Ditto.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-args-validity-3.diff
Type: text/x-diff
Size: 3152 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20010915/1a4bfeab/attachment.bin>
More information about the Cygwin-patches
mailing list