experimental texmf packages
Fri Nov 2 13:58:00 GMT 2001
----- Original Message -----
From: "Jan Nieuwenhuizen" <firstname.lastname@example.org>
> > > * Makefile.in (CFLAGS): Remove -Werror to allow build.
> > The Werror is in by design. If your patch won't build with it, I
> > accept you patch.
> Ah, good. But it was not for my patch! The latest cvs setup.exe
> won't build without it, in my environment. I get warnings (-> errors)
Ok, those look like updated w32api stuff that needs prototypes added. I
had to do that the first time I added -Werror as well. (Hint, Hint) It'd
be great if patches added to core things like w32api were checked with
all -Werror and all warnings on before being committed.
> > > * configure.in (LIB_AC_PROG_CXX): Bugfix for CXXFLAGS override.
> > What's wrong with the current method?
> At some point, it feeds $(CXXFLAGS) to the shell, which complains that
> CXXFLAGS is not a command.
Doesn't for me. Can you find where? (Make should be doing the
> > > * desktop.cc (etc_profile): Remove line breaks and spaces from
> > The line is now > 80 chars, and indent will break it up again. Is
> > some reason for this change?
> Ah, that's how this bug got in, probably. You may not notice it
> because your /etc/profile won't be overwritten, or you have your own
> PS1, but the default prompt from unpatched install looks like this:
Strange. C strings without \n should be a single line when output,
regardless of the in-source
formatting. I'll have look at this. (Not that I don't want to fix the
bug, but I want to know the root cause.
> > > * package_meta.cc (try_run_script): New function.
> > This doesn't belong here. It's nothing to do with the package, but
> > interfacing with the shell/scripts. Also (this one is
> > cygpath and _access are deprecated - foo = io_stream::open (concat
> > ("cygfile://", dir, fname, 0), "rb") followed by run_script (foo)
> > be the more OO approach here.
> > In the future I think we'll want a script or shell class to
> > all of this.
> Ok. In short: I tried to update the patch with a minimal amount of
> extra/moved code. The comments suggest that pkg managent is still in
> flux. I can fix the file exists check, but where do you want the
> function to go?
pkg management is very much in flux. There is a lot to do :]. I'm simply
trying to make each step robust and self contained. Lets make a new
script.cc and script.h. Put the functions there, they can get OOPified
> Btw: is someone working on conflicts: or more versatile requires:? I
> may want to have a look at adding versioned and/or alternative
> requires. It would be easiest to change the syntax to something like:
> It's a quite small patch, if the functionality is ok, I guess I/we can
> fix these details?
Please do. Conflicts is on the wishlist, but not actively being
developed right now.
The reason for that issue is that we need a pop-up screen, perferrably a
sublist from the chooser of _all_ the affected packages. (Consider a
conflict with ash, everything that depends on ash needs to be shown as
getting uninstalled). And that popup needs a
backout-without-altering-what-I-had option to allow folk to undo a
mistaken click easily. And that needs me to finish the rationalisation
and multi-instance work I'm doing on the package chooser.
You're welcome to submit a patch that parses the conflict list though.
Also needed is a Provides: clause (ash provides sh, bash provides sh,
tcsh provide sh).
Likewise, for now just adding the parsing capability is a good start.
Requires should also be able to require by version - ie
requires: foo > _opaque_-1
requires: foo = _opaque_-1
requires: foo >= _opaque_-1
should all be valid.
I don't think we need < in the requires clause. That is implemented by a
conflicts > clause.
More information about the Cygwin-patches