setup.exe remove scripts [Was: Re: experimental texmf packages]

Robert Collins
Mon Nov 5 17:15:00 GMT 2001

----- Original Message -----
From: "Jan Nieuwenhuizen" <>

> "Robert Collins" <> writes:
> > I suspect that that is actually by design.Look at revision 1.2 of
> > and it has the same ,'s causing separate lines.
> So maybe it was very late when the code was designed :-)  Removing
> > I don't really have an opinion on whats right here,
> Ok.  I like having just a one-line prompt.

See my other emails. Lets leave this to the side, it's orthogonal to the
remove script work you've done.

> > but FWIW my prompt always appears on one line

I'm wrong here, it's on two lines, I'm just losing the plot :}. I
actually like the two line approach.

> Remaining nits fixed in patch below.  Btw, some nits are so small,
> imo, that you're free to just say: Removed/fixed than going throught
> the mail/reply dance, if that's more convenient for you.

Hm, lets see :}

> Greetings,
> Jan.
> > Please put all changes related to a single file in one place.
> Ah, ok.  That was because I see it as separate patches, and kept
> chronicity.

Which doesn't make sense (to me) as you would need multiple change log
entries to really preserve that.

> > > * (CFLAGS): Remove -Werror to allow build of w32api
> > > headers
> >
> > This will not be accepted. if w32api is broken, revert it to an
> > date
> Removed [, but I don't quite understand.  That is, I understand this
> is the wrong fix, but I can't go and submit patches with global
> impact; or hold my patch up and go diving into w32api first?  Where I
> come from, it's: Thou shalt not check in something that doesn't
> compile.]

Right. Well setup compiled before w32api got broken. I've said it twice
now: revert your w32api (which is what's broken) and setup will build

Fixing w32api again is important, and can be address'd in parallel.
Anyone that wants to build setup.exe will have motivation to fix w32api

> * (do_install): Run script initialisation.  Typo fix.

This is still wrong :}.
The Typo fix is not part of the do_install function - so it goes like
    * Typo fix.

and then we have the do_install changes which are entered liek
    (do_install): Run script initialisation.

giving us
    * Typo fix.
    (do_install): Run script initialisation.

Which was the example I provided.

I'm accepting this patch as is given your disclaimer above so don't
worry about another round circuit.

I'll apply it within the next 24 hours.


More information about the Cygwin-patches mailing list