[PATCH] Update 2 - Setup.exe property sheet patch

Robert Collins robert.collins@itdomain.com.au
Thu Nov 8 12:50:00 GMT 2001


Having had a good close look, there is a little more that is needed
before committing to CVS.

1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what
was breaking local_dir. (Oh, and the functions weren't virtual in some
child classes :}).
2) See download.cc - is next_dialog still used, and should a fail result
in the previous behaviour?

I've attached an updated patch for you with the virtual functions
actually still virtual.

Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Gary2.patch.bz2
Type: application/octet-stream
Size: 27671 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20011108/803a710f/attachment.obj>


More information about the Cygwin-patches mailing list