[Patch] setup.exe - no skip/keep option buggyness

Robert Collins robert.collins@itdomain.com.au
Fri Nov 9 15:44:00 GMT 2001


----- Original Message -----
From: "Gareth Pearce" <tilps@hotmail.com>
To: <robert.collins@itdomain.com.au>; <cygwin-patches@cygwin.com>


...
> Would have submited another go ... but what you have done looks great
(A
> more significant change then I would have submited, but then I am in
newbie
> cautious mode), and I am in the middle of a 336meg download of debian

I've put your patch into the categories branch, and into HEAD.

As for being cautious .... I'll accept any patch, big or small, that
a) is inline with the setup.exe goals. If in doubt the issue can be
discussed to it's death on cyg-apps.
b) is coded well. return values checked, snprintf instead of sprintf
etc.
c) is designed well (IOW doesn't make the internal maintenance harder).

I understand not wanting to spend a lot of time on a big patch, just to
get the patch rejected, so discussing the concept first on cyg-apps is
usually a good idea for non-obvious or structural work.

Rob



More information about the Cygwin-patches mailing list