[PATCH] Update 2 - Setup.exe property sheet patch

Robert Collins robert.collins@itdomain.com.au
Thu Dec 20 04:08:00 GMT 2001

Last time around hopefully!

1) format your changelog with line wrap at 80 columns.
2) It's a changelog, so if you #if 0 and then remove a function during
your local testing, the final change is actually just a remove.
Likewise, chooser.[cc|h] should not be mentioned because it never exists
(from CVS's viewpoint).
3) You've _Still_ got blank lines in the log.
4) You've got multiple log entries - this is going in as a single
commit, so thats inappropriate (IMO, open to discussion).

In a nutshell: This is a Changelog from CVS 'NOW' to CVS 'after the
The acid test I recommed you perform is to walk through the .diff with
the changelog
open beside you. Make sure all changes are listed, and you also get to
do a code walkthrough for free.

5) (Blame me) Remove the change to link against comctl32 - thats in CVS
now (I've checked in my working dir as I recently got stable again the
chooser). (Which, IMO is starting to 'get there'.)

It's not a historical set of notes that you've gone through in your
sandbox but rather an explanation of the desired effect of the change
getting committed.

Don't worry about sending updated source, I just need the ChangeLog and
it'll all get committed.


----- Original Message -----
From: "Gary R. Van Sickle" <g.r.vansickle@worldnet.att.net>
To: <cygwin-patches@sourceware.cygnus.com>
Sent: Thursday, December 20, 2001 5:19 PM
Subject: [PATCH] Update 2 - Setup.exe property sheet patch

> Changes as per your (Rob) last email, plus a few other improvements.
Diff, new
> files, and ChangeLog attached.
> --
> Gary R. Van Sickle
> Brewer.  Patriot.

More information about the Cygwin-patches mailing list