[PATCH] Update 2 - Setup.exe property sheet patch

Robert Collins robert.collins@itdomain.com.au
Thu Dec 20 13:17:00 GMT 2001

----- Original Message -----
From: "Gary R Van Sickle" <tiberius@braemarinc.com>
> "Once virtual, always virtual", i.e., it isn't necessary to add
"virtual" to
> any overridden virtual functions, and in fact it's not possible to
> "unvirtualize" once virtualized.  I do try to maintain them as a
> convention, but even I fall short sometimes ;-).  Thanks for patching

My understanding is that this is not 100% the case. Or more
pedantically - in a class derived from a a class with virtual functions,
those virtual functions wil get overriden, but if not declared virtual
themselves, any further derivations will not. I believe that the
technique of doing this to allow inlining of code calling references to
an object is called 'final classes'.

> > 2) See download.cc - is next_dialog still used, and should a
> > fail result
> > in the previous behaviour?
> >
> I believe it is still used in a few places (some of the "do_xxx"'s).
> whole mechanism is one of the next things to go.  As far as behavior
> concerned, I'm trying hard to specifically *not* change any at this
> but simply to get the new property page and class foundation laid
> he sez ;-)).  So you're saying that a download failure isn't being
> properly?

I think that 2 things are broken:
1) A local install doesn't.
2) A failure during download may not behave correctly - but I don't


More information about the Cygwin-patches mailing list