For the curious: Setup.exe char-> String patch

Robert Collins
Fri Feb 1 18:47:00 GMT 2002

> -----Original Message-----
> From: Gary R Van Sickle []
> I think it would behoove us greatly to duplicate the semantics of
> std::string here, and return a zero-based offset on success, 
> and an "npos"
> on failure.
Whats a 'npos' defined as?
> >
> >
> >  static void
> > -init_dialog (char const *url, int length, HWND owner)
> > +init_dialog (String const url, int length, HWND owner)
>                 ^^^^^^^^^^^^^^^^
> This would be better written "const String &url".

Weeel, yes it would, yet another typo. Fortunately String copies are
very lightweight :}.
(One addition, one subtraction, and if test and 4 bytes of storage)


More information about the Cygwin-patches mailing list