Rebase Patch Review

Jason Tishler
Mon Feb 11 11:29:00 GMT 2002


On Sat, Feb 09, 2002 at 12:35:28AM -0800, Michael A Chase wrote:
> I've looked the patch over and don't see any obvious problems.  My technical
> knowledge of C++ has some severe limits though.

Thanks for the review -- I appreciate your efforts.

> It might be better to have rebase in some of the names; rebase_config
> instead of config_file for example.

The above is one of those "niggling" items that I indicated in my post.
I was intending to prevent setup.exe global name space pollution by using
namespaces (if necessary), but I'm willing to change names if that is
more preferable.


More information about the Cygwin-patches mailing list