[PATCH]setup.exe passwd-grp.bat being created when not needed

Michael A Chase mchase@ix.netcom.com
Mon Feb 18 16:40:00 GMT 2002


Currently /etc/postinstall/passwd-grp.bat is opened before the need for it
is determined.  This results in the file always being executed even though
it is normally empty.   This patch may eliminate the flashing console window
at the end of setup.exe when no action is expected.

I left the iostream::mkpath_p() call at the top of the function to make sure
/etc/postinstall/ always exists after make_passwd_group() is called.  This
appears to be the only place the directory is created explicitly.

Sorry for the separate patches.  The two issues are independent and I didn't
notice this until I'd already sent the previous patch.  The patches may be
combined if you wish.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.htm
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.

ChangeLog:

2002-02-18  Michael A Chase <mchase@ix.netcom.com>

    * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
unnecessarily.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cinstall-mac-020218-2.patch
Type: application/octet-stream
Size: 1024 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020218/b02c07dc/attachment.obj>


More information about the Cygwin-patches mailing list