[Patch]setup.exe type prefixes for io_stream::mkpath_p and io_stream:open paths

Michael A Chase mchase@ix.netcom.com
Sun Feb 24 17:19:00 GMT 2002


----- Original Message -----
From: "Robert Collins" <robert.collins@itdomain.com.au>
To: "Michael A Chase" <mchase@ix.netcom.com>; "Jan Nieuwenhuizen"
<janneke@gnu.org>
Cc: <cygwin-apps@cygwin.com>
Sent: Sunday, February 24, 2002 02:44
Subject: Re: setup.exe /var, /tmp?


> ----- Original Message -----
> From: "Michael A Chase" <mchase@ix.netcom.com>
>
> > These are probably not the only places where the prefixes may be
> missing.
> > Would it be worthwhile to add a log() call if no "file://" or
> "cygfile://"
> > prefix is found in io_stream::mkpath_p()?
>
> Possibly in your sandbox. I don't feel the need in CVS though :}.
>
> > I'm doing a search for all the mkpath_p() calls I can find, but often
> the
> > file or directory name is passed from somewhere else.
>
> Thank you.

I also looked through the calls to io_stream*::open() and found a couple
places that appeared to be missing the required prefix in
io_stream_cygfile.cc.

Robert,

To avoid confusion, perhaps cygpath() should be renamed native_path() or
natpath().  I could make that change fairly easily if you want.

--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.

ChangeLog:

2002-02-24  Michael A Chase <mchase@ix.netcom.com>

    * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
call.
    (make_passwd_group): Ditto.
    * localdir.cc (save_local_dir): Ditto.
    * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
    Add "file://" prefix to io_stream::open() calls.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cinstall-mac-020224-1.patch
Type: application/octet-stream
Size: 2051 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020224/c4d6174c/attachment.obj>


More information about the Cygwin-patches mailing list