Patch for Setup.exe problem and for mklink2.cc

[Robert Collins]

> -----Original Message-----
> From: Ton van Overbeek [mailto:tvoverbe@cistron.nl] 
> Sent: Thursday, March 28, 2002 1:03 AM
> To: cygwin-apps@cygwin.com; cygwin-patches@cygwin.com
> Cc: jonas_eriksson@home.se
> Subject: Patch for Setup.exe problem and for mklink2.cc
> 
> 
> Found the problem causing the segment violation and probably 
> causing Jonas Eriksson's problem. It is a typical case of 
> 'off by 1'. In PickView::set_headers the loop filling the 
> window header does one iteration too much, resulting in a 
> call to DoInsertItem with a NULL string pointer and hence a 
> crash following. While debugging this I could not compile the 
> new mklink2.cc ( the
> c++ version of the original mklink2.c). It seems three & (address of 
> c++ operator)
> have disappeared in the transition. Putting them back made 
> the compiler happy. Is this OK Robert ?

I'll check the off-by-one fix in tomorrow, as I'm off to bed now. 

As for the &'s, I wonder if it's a w32api reference issue? The compiler
complains if they are present for me.

I have the latest-and-greatest w32api headers on my system - what do you
have?

Thanks for finding the off-by-one... blush.

Rob