Corinna or Pierre please comment? [ Re: setuid

Corinna Vinschen
Tue Jul 23 05:55:00 GMT 2002


since your patch is applied, Cygwin handles user switches even when
the DC isn't available.  Now, in another thread in the cygwin ml,
there's a report of a situation, where the DC *is* available but
it doesn't allow anonymous access to request the group list.
NetUserGetGroups() returns ERROR_ACCESS_DENIED.  This can happen
on 2K and .NET servers according to

(see the Remarks section).

So we still have a problem, even if the DC is accessible.  We could
solve that by not failing silently if the get_user_groups() function

RCS file: /cvs/src/src/winsup/cygwin/,v
retrieving revision 1.115
diff -u -p -r1.115
---	19 Jul 2002 23:48:17 -0000	1.115
+++	23 Jul 2002 12:52:41 -0000
@@ -526,9 +526,8 @@ get_group_sidlist (cygsidlist &grp_list,
       extract_nt_dom_user (pw, domain, user);
       /* Fail silently if DC is not reachable */
-      if (get_logon_server (domain, server, wserver) &&
-	  !get_user_groups (wserver, grp_list, user, domain))
-	return FALSE;
+      if (get_logon_server (domain, server, wserver))
+	get_user_groups (wserver, grp_list, user, domain);
       get_unix_group_sidlist (pw, grp_list);
       if (!get_user_local_groups (grp_list, usersid))
 	return FALSE;

What do you think?  Somehow I hate to soften the behaviour but it
seems to be inescapable...


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                      
Red Hat, Inc.

More information about the Cygwin-patches mailing list