serial patch - second attempt

Corinna Vinschen cygwin-patches@cygwin.com
Wed Jul 24 04:01:00 GMT 2002


On Wed, Jul 24, 2002 at 10:30:52AM +0200, Jacek Trzcinski wrote:
> What can I say ? I do not know reason You changed wincap.is_winnt() on
> wincap.must_init_serial_line(). In my opinion conditionals utilizing

The reason to use wincap is to not ask for operating systems as far
as possible but instead to ask for a specific capabilities of the
system we're just running on.  Nobody actually cares if the system
is a 95 OSR2 or a NT4 SP5.  CInstead, by using specific capabilities
the code itself answers the question "why are we doing this" e. g.:

  if (wincap.has_lseek_bug ())
    workaround;

Doesn't that make sense?

> is_wint() are better but if You do want to change it I suggest something
> like wincap.support_modem_output_lines_reading
> which is accurate to function it serves to.

Ok, I've choosen 'supports_reading_modem_output_lines'

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.



More information about the Cygwin-patches mailing list