[PATCH] pthread_fork

Robert Collins rbcollins@cygwin.com
Thu Aug 15 18:10:00 GMT 2002

On Fri, 2002-08-16 at 04:27, Thomas Pfaff wrote:
> This patch will fix the pthread key related problems with fork (key value
> is restored after fork) and some minor fork related fixes.

Thomas, Some feedback on this. (I know, less than a week - wow!)

Some general things:
MTinterface::init_pthread is breaking encapsulation of pthread, please
correct this.

You have moved more class specific code in to MTinterface. This further
breaks abstraction FWICS. Can you enlarge on your reasons for that?

Finally it seems to me that the pthread_before_fork new call could
(should) be called from pthread_atfork_prepare.

This is a rather big patch, covering several different things -
refactoring list code, altering initialisation of pthread classes,
handling fork better for pthreads, handling fork for pthead_key's. I'd
really like to see it as as series of smaller patches to debate more


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020815/89a6d23c/attachment.sig>

More information about the Cygwin-patches mailing list