More changes about open on Win95 directories.

Christopher Faylor cgf@redhat.com
Wed Sep 18 20:33:00 GMT 2002


On Wed, Sep 18, 2002 at 10:02:25PM -0400, Pierre A. Humblet wrote:
>I fixed all that by adding set_nohandle () and get_nohandle () appropriately.
>To avoid submitting patches on top of yesterday changes, I include cumulative 
>changes for the last two days.
>
>Also, on line 476 of fhandler_disk_file.cc, in lock,  I see
>  if (fl->l_len < 0)
>    {
>      win32_start -= fl->l_len;
>      win32_len = -fl->l_len;
>    }
>It seems to me that we want to decrement win32_start, which would mean
>we should add the negative fl->l_len, or am I confused?

I've looked at that code a few times and wondered about that.  It seems
backwards but maybe someone else has more insight.

>And yesterday's question: On line 173 of fhandler_disk_file.cc 
>[strpbrk (get_win32_name (), "?*|<>|")] is there a need for the 
>two '|'? Was something else meant?

I removed it.  I don't know if there is another invalid character that
should go there or not, though.

I've checked in the rest of your patch with some minor formatting fixes
to the ChangeLog and code.

FYI, it is not GNU standard to do:

  if (foo) bar = 1;

It should be

  if (foo)
    bar = 1;

Anyway, thanks for the patch.  It looks really useful.

cgf



More information about the Cygwin-patches mailing list