[PATCH] pthread_fork Part 3

Robert Collins rbcollins@cygwin.com
Fri Sep 20 05:50:00 GMT 2002


On Sat, 2002-08-17 at 06:55, Thomas Pfaff wrote:
> 
> Pthread key destructor handling revised. IMHO it does not make sense to
> handle two lists with keys, one with all keys, one with its destructors.
> The destructors are now part of the key class.

I agree with the duplication of code. This is one area I'd really really
really like to use templates. 

Chris, Corinna, if we ever get the chance to use templates please tell
me so! It makes code clarity and size so much better.

Anyway, yes, we should only have one list. So yes, please do refactor
the two together in the way I've arranged the pthread_keys::keys list.

Note that you have a comment on non thread safeness in the new
pthread_keys code. I thought I had addressed that in my list code, could
you either tell me I was also not thread safe, or correct that at the
same time?

Cheers,
Rob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020920/56b39c2c/attachment.sig>


More information about the Cygwin-patches mailing list