[PATCH] fhandler_tty doecho change

Steve O bub@io.com
Tue Sep 24 08:56:00 GMT 2002

On Tue, Sep 24, 2002 at 10:37:23AM -0400, Christopher Faylor wrote:
> On Tue, Sep 24, 2002 at 09:21:43AM +0200, Corinna Vinschen wrote:
> >This looks interesting but is actually missing a ChangeLog entry.

Here's the ChangeLog patch.

> I don't think we have an assignment on file for Steve, either.

Crud.  Anyone want to write a few patches to the tty code?  

I was thinking about the deadlock problem some more last night, 
and it occured to me that if termios processing were done on 
the slave side, some of the buffering and tricky bits of 
flushing the write buffer would go away (maybe).  And you wouldn't
need this patch. 


Index: ChangeLog
RCS file: /cvs/src/src/winsup/cygwin/ChangeLog,v
retrieving revision 1.1497
diff -r1.1497 ChangeLog
> 2002-09-23  Steve Osborn  <bub@io.com>
>       * fhandler.h: (fhandler_pty_master::get_echobuf_valid): Added.
>       (fhandler_pty_master::get_echobuf_into_buffer): Added.  
>       (fhandler_pty_master::clear_echobuf): Added.    
>       (fhandler_pty_master::ebbuf): Added pointer to echobuf.
>       (fhandler_pty_master::ebixget): Added echobuf get index.
>       (fhandler_pty_master::ebixput): Added echobuf put index.
>       (fhandler_pty_master::ebbuflen): Added echobuf length.
>       (fhandler_pty_master::ebguard): Added handle for guard mutex.
>       * fhandler_tty.cc: (fhandler_pty_master::get_echobuf_valid): Added.
>       (fhandler_pty_master::get_echobuf_into_buffer): Added.  
>       (fhandler_pty_master::clear_echobuf): Added.
>       (fhandler_pty_master::process_slave_output): prime read with echobuf.
>       (fhandler_pty_master::fhandler_pty_master): initializers for echobuf.
>       (fhandler_pty_master::open): calls clear_echobuf.
>       (fhandler_pty_master::close): calls clear_echobuf.
>       * select.cc: (peek_pipe): check for echobuf valid.

More information about the Cygwin-patches mailing list