open() not handling previously opened serial port gracefully?

Christopher Faylor cgf@redhat.com
Thu Oct 31 16:31:00 GMT 2002


On Thu, Oct 31, 2002 at 07:20:06PM -0500, Pierre A. Humblet wrote:
>This fixes 
>http://sources.redhat.com/ml/cygwin/2002-10/msg01792.html

Go ahead and check this in, Pierre.

Thanks for tracking it down.

cgf

>2002-10-31  Pierre Humblet <pierre.humblet@ieee.org>
>
>	* fhandler.cc (fhandler_base::open): Verify pc isn't NULL.
>
>--- fhandler.cc.orig    2002-10-31 18:46:24.000000000 -0500
>+++ fhandler.cc 2002-10-31 18:47:38.000000000 -0500
>@@ -442,7 +442,7 @@ fhandler_base::open (path_conv *pc, int 
> 
>   if (x == INVALID_HANDLE_VALUE)
>     {
>-      if (pc->isdir () && !wincap.can_open_directories ())
>+      if (!wincap.can_open_directories () && pc && pc->isdir ())
>        {
>          if (mode & (O_CREAT | O_EXCL) == (O_CREAT | O_EXCL))
>            set_errno (EEXIST);



More information about the Cygwin-patches mailing list