cygwin part of pseudo-relocs patch

Christopher Faylor cgf@redhat.com
Fri Nov 15 08:10:00 GMT 2002


On Tue, Sep 03, 2002 at 10:38:20AM +0400, egor duda wrote:
>This is an updated cygwin part of pseudo-relocs patch.  Relocations are
>performed inside of cygwin1.dll, as Chris suggested, and it seems to
>work ok in case of one dll referencing another one.  After new binutils
>package is released, it can go into cygwin release.

Just to get a head start on reviewing this, I wanted add some more
comments.

I can see code in dll_crt0_1 being called for handling relocs.  Is it
your intent that every new DLL will have to specifically call
_pei386_runtime_relocator?

I can see that over ld-land you are generating an undefined reference for
this symbol if the --enable-runtime-pseudo-reloc switch is used.  Is this
just to ensure that there is an error message when linking with a new
version of binutils but an older version of a dll that's being built?

I was thinking that a call to this code would live in the application
but obviously that's wrong.  It has to live in the DLL.  Wouldn't that
mean that it should be added somehow to _cygwin_dll_entry
winsup/cygwin/include/cygwin/cygwin_dll.h ?

cgf



More information about the Cygwin-patches mailing list