[PATCH] Patch for MTinterface
Sun Nov 24 05:55:00 GMT 2002
On Sat, 2002-11-23 at 01:55, Thomas Pfaff wrote:
> On Tue, 5 Nov 2002, Robert Collins wrote:
> > Overall this looks good. What happens to non-cygwinapi created threads
> > now though? You mention you don't agree with the code, but I can't see
> > (from a brief look) how you correct it.
> > BTW: I'm currently packing to move house, so don't expect much feedback
> > until late next week, or early the week after :[.
Pong. I've added the test cases to the test suite. In future please
follow the guidelines in testsuite/readme for test behaviour - running
$ ./testname || echo foo
should echo foo on failures - and neither of your test cases did that
Also, the initMainThread behaviour:
initMainThread (bool dosomething)
I don't like. I'd rather we not call initMainThread than call it with a
boolean as above.
If dosomething was internal to the pthread class, so that initMainThread
I'd have no issue.
Anyway, thanks again for excellent work, and the patch has been
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the Cygwin-patches