Corinna Vinschen
Wed Feb 5 14:50:00 GMT 2003

On Wed, Feb 05, 2003 at 09:15:05AM -0500, Pierre A. Humblet wrote:
> is_grp_member is now unused and will disappear in the next installment.

You did it ;-)

> Three remarks:
>    Is that what you meant?

I don't know what you mean by "Is that what you meant?".  What are you
referring to?  However, it's incorrect.  The permission to write does
include all standard rights.  So the STANDARD_RIGHTS_ALL is correct.

> 2) Because of the ~DELETE stuff in setacl, the owner may not have DELETE
> right, 
>    even when the file is writable. unlink calls chmod if needed so it's OK

I think you misinterpreted the code slightly.  Some lines earlier, the
Win32 permissions are set according to the POSIX permissions.  The right
to write includes STANDARD_RIGHTS_ALL which includes the right to DELETE.

In the lines you're referring to, the owner of the file gets the
STANDARD_RIGHTS_ALL, regardless of the permission bits set some lines
earlier.  However, the right to DELETE is only set in conjunction with
the write permisssion.  It must not be set unconditionally in these lines.

So everything's fine if you don't change STANDARD_RIGHTS_ALL to
STANDARD_RIGHTS_WRITE some lines before ;-)

> 3) In I had to move set_process_privilege back to write_sd
>    because setacl may need it.

That's ok.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                      
Red Hat, Inc.

More information about the Cygwin-patches mailing list