[PATCH] pthread_equal

Robert Collins rbcollins@cygwin.com
Wed Mar 19 22:05:00 GMT 2003

On Thu, 2003-03-20 at 00:54, Thomas Pfaff wrote:
> 2003-03-19  Thomas Pfaff  <tpfaff@gmx.net>
> 	* pthread.cc (pthread_equal): Replacement for pthread_equal in
> 	thread.cc.
> 	* thread.cc: Rename pthread_equal to pthread::equal throughout.
> 	(pthread_equal): Remove.
> 	* thread.h (pthread::equal): New static method.

This seems mostly pointless to me.

A few notes:

Why use a static method? you'll always have one pthread to compare to ,
so using operator == is appropriate. In fact, operator == already does
the right thing as it is the entire contents of pthread_equal.

So: where pthread_equal is used internally, you could switch to (for
 if (&thread == joiner)

GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20030319/585cc420/attachment.sig>

More information about the Cygwin-patches mailing list