Patch for line draw characters problem & screen scrolling

Corinna Vinschen cygwin-patches@cygwin.com
Wed May 21 16:24:00 GMT 2003


On Wed, May 21, 2003 at 06:00:05PM +0200, Micha Nelissen wrote:
> Hi,
> 
> > First of all, this is a big patch which requires an assignment
> > which copies over the copyright ownership to RedHat.
> 
> Ok, but where to send this assignment form?

The address is given on the form (just click the appropriate link):

  Rose Naftaly
  Red Hat, Inc.
  444 Castro Street
  Suite 1200
  Mountain View, California 94041 USA

This will take some time but it's required, sorry.

> > Second, the ChangeLog doesn't adhere to the ChangeLog standards.
> 
> I have taken a look at http://www.gnu.org/prep/standards_42.html. On what
> ground(s) does it not comply?

Well, it should adhere to the other ChangeLog entries in the same file
at least :-)  Just looking into the existing ChangeLog file should give a
clue.  It consists of a specifc set of tabs, colons and other characters
at the right spot.  Just an examples:

Not

* foo.c (bar): blah blah
* foo.c (baz): more blah
* foobar.c (fooy): even more blah

but

	* foo.c (bar): Blah blah.
	(baz): More blah.
	* foobar.c (fooy): Even more blah.

And there's e.g. no need to rationalize the patch in the ChangeLog.
Just write *what* you did, not *why* you did it.  If it's not clear
from the code, add comments there.

It's actually not really hard, just a process to get used to it.
No worries.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.



More information about the Cygwin-patches mailing list