[PATCH] Re: [corinna-cygwin@cygwin.com: Re: ENOTSOCK errors with cygwin dll 1.3.21 and 1.3.22]

Corinna Vinschen cygwin-patches@cygwin.com
Tue May 27 09:07:00 GMT 2003

On Tue, May 27, 2003 at 10:19:53AM +0200, Thomas Pfaff wrote:
> > > +        CloseHandle (ev[0]);
> >            ^^^^^^^^^^^
> > 	   ...shouldn't that be a WSACloseEvent?
> >
> Of course you are right. I have fixed this.
> In reality this shouldn't make any difference since WSACreateEvent will use
> CreateEvent and the handles are therefore compatible.

Yes, I guessed so.  It's all a handle after all.  It's just cleaner to
use the expected function, though, I'm not that sure when it comes to

So, that's ok to check in with a minor change in connect:

> +  if (res && !is_nonblocking () && !is_connect_pending () &&
>        WSAGetLastError () == WSAEWOULDBLOCK)

It's not your fault, it was already this way in the unpatched code
but I thought while you're at it it doesn't hurt.  Could you please
apply this as

     if (res && !is_nonblocking () && !is_connect_pending ()
         && WSAGetLastError () == WSAEWOULDBLOCK)

?  Just move the && to the beginning of the next line, that would be nice.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.

More information about the Cygwin-patches mailing list