Signal handling tune up.
Christopher Faylor
cgf@redhat.com
Tue Aug 19 00:34:00 GMT 2003
On Mon, Aug 18, 2003 at 08:17:36PM -0400, Pierre A. Humblet wrote:
>During my work on using the multimedia timer for setitimer I noticed
>that Cygwin was not optimized to handle 1000 signals per second.
>It starts trashing under heavy load. Attached is a tune up patch.
>It also modestly improves performances at light load and fixes a
>race condition.
>
>Some explanations are in order, here they are.
I will break down your patch and apply what I think is appropriate but
I would appreciate one patch/one bug in the future.
For now, I've applied this:
>*********************************************************************
>2)
> movl $0,%0 # zero the signal number as a \n\
> # flag to the signal handler thread\n\
> # that it is ok to set up sigsave\n\
> \n\
> call _set_process_mask@4
>There is a race where the sigthread can start a handler for a signal that
>should be blocked.
>Simply interchanging the order still allows the sigthread to try to launch
>a handler (before the mask is set), discovers that sigsave is busy and takes
>cumbersome actions (e.g. Sleep).
>The patch moves set_process_mask all the way up to interrupt_setup(), so
>it is set in the sigthread itself.
cgf
More information about the Cygwin-patches
mailing list