Part 2 of Fixing a security hole in mount table.
Wed Sep 10 07:54:00 GMT 2003
On Tue, Sep 09, 2003 at 11:54:26PM -0400, Pierre A. Humblet wrote:
> 2003-09-10 Pierre Humblet <firstname.lastname@example.org>
> * shared_info.h (shared_info::initialize): Remove argument.
> * cygheap.h (cygheap_user::init): New declaration.
> * uinfo.cc (cygheap_user::init): New.
> (internal_getlogin): Move functionality to cygheap_user::init.
> Open the process token to update the group sid.
> * shared.cc (user_shared_initialize): Get the user information
> from cygheap->user.
> (shared_info::initialize): Remove argument. Call cygheap->user.init
> instead of cygheap->user.set_name.
> (memory_init): Do not get the user name and do not pass it to
> * registry.cc (get_registry_hive_path): Make csid a cygpsid.
> (load_registry_hive): Ditto.
Looks good to me, except for:
> - char name[UNLEN + 1] = "";
> + char name[UNLEN > 127 ? UNLEN + 1 : 128] = "";
Huh? Why that? UNLEN is defined as 256 in lmcons.h so I don't understand
the reasoning behind that complexity.
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:email@example.com
Red Hat, Inc.
More information about the Cygwin-patches