[Patch] Recent security improvements breaks proftpd

Pierre A. Humblet pierre@phumblet.no-ip.org
Fri Sep 26 13:43:00 GMT 2003

Corinna Vinschen wrote:
> On Fri, Sep 26, 2003 at 02:53:28PM +0200, Corinna Vinschen wrote:
> > Btw., shouldn't that be
> >
> >   SetTokenInformation (ptok, TokenDefaultDacl, pdacl, pAcl->AclSize)
> >                                                       ^^^^^^^^^^^^^
> >                                                     instead of sizeof(buf)?
> Urgh.  What I meant was:
>   sizeof *pdacl + pAcl->AclSize
That makes for 3 possibilities but there is a 4th one: sizeof (* pdacl) 
(i.e. 4 bytes).
That's what a strict reading of MS would imply. I think I tried it once
(in another case) and it worked, but I never used it because it was contrary
to Cygwin tradition. 
I may also be mixing up my facts.

No problem about changing the buffer size, of course, and also #defining a constant.
Out of curiosity, have you ever seen a long default DACL?


More information about the Cygwin-patches mailing list