New program: cygtweak

Igor Pechtchanski pechtcha@cs.nyu.edu
Tue Sep 30 15:29:00 GMT 2003


On Tue, 30 Sep 2003, Christopher Faylor wrote:

> On Tue, Sep 30, 2003 at 11:02:39AM -0400, Igor Pechtchanski wrote:
> >On Tue, 30 Sep 2003, Corinna Vinschen wrote:
> >> Wouldn't it be sufficient to add $(srcdir)/cygprogctl to PROGS and to
> >> drop the copy rule?  The script only needs installing and that should
> >> work then.
> >
> >I just remembered why I did it this way: aren't all of the $(PROGS) are
> >deleted on "make clean"?  If I added $(srcdir)/cygprogctl to PROGS, I'd
> >have to change the "clean" rule.  I thought a copy would be easier and
> >less intrusive.
>
> Good point, but I think I'd prefer something like:
>
>   install: all cygprogctl
> 	  $(SHELL) $(updir1)/mkinstalldirs $(bindir) $(etcdir)
> 	  for i in $(PROGS) ${word 2,$^} ; do \
> 	    n=`echo $$i | sed '$(program_transform_name)'`; \
> 	    $(INSTALL_PROGRAM) $$i $(bindir)/$$n; \
> 	  done
>
> That would just let the standard install deal with installation.
> cgf

Hmm, then it'll have to be

install: all $(srcdir)/cygprogctl
	...

How is this cleaner than adding it to PROGS?  PROGS only appears as a
dependence in the "all" rule, as a value for CLEAN_PROGS, and in the for
loop in the "install" rule.

Wait, doesn't ":=" expand the asigned value immediately?  Then Corinna's
right, and adding to PROGS after the assignment to CLEAN_PROGS will not
change CLEAN_PROGS (so the copy is redundant).  It would simply become

Index: winsup/utils/Makefile.in
===================================================================
RCS file: /cvs/src/src/winsup/utils/Makefile.in,v
retrieving revision 1.53
diff -u -p -r1.53 Makefile.in
--- winsup/utils/Makefile.in    12 Sep 2003 01:51:21 -0000      1.53
+++ winsup/utils/Makefile.in    27 Sep 2003 16:24:54 -0000
@@ -84,6 +84,8 @@ PROGS:=warn_dumper $(PROGS)
 CLEAN_PROGS+=dumper.exe
 endif

+PROGS+=$(srcdir)/cygprogctl
+
 .SUFFIXES:
 .NOEXPORT:


Sorry for the confusion,
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton



More information about the Cygwin-patches mailing list