[Patch]: Ncurses frame drawing

Micha Nelissen M.Nelissen@student.tue.nl
Wed Oct 15 18:47:00 GMT 2003


Corinna Vinschen wrote:

> On Wed, Oct 15, 2003 at 08:50:09AM +0200, Micha Nelissen wrote:
> 
>>Pierre A. Humblet wrote:
>>
>>>FWIW, wouldn't it be cleaner to make "alternate_charset_active" a 
>>>member of dev_state instead of introducing a new global variable?
>>
>>1) that alternate_charset check which currently is in str_to_con 
>>(centralized), needs to dispersed over all calls to str_to_con. 
>>(Currently, 1, AFAICS). Prone to bugs, if you ask me because this could 
>>be forgotten in the future, unless this one call will remain the only one.
>>2) str_to_con has to become a member of dev_state too.
> 
> 
> Point 2 has some merits.  Are you interested to do that change, Micha?
> Of course, con_to_str should become a dev_state member then, too.

Ok, attached is a patch with the requested changes.

Regards,

Micha.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: charset2.patch
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20031015/5987ef2c/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: charset2.log
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20031015/5987ef2c/attachment.log>


More information about the Cygwin-patches mailing list