[PATCH] stdio initialization

Thomas Pfaff tpfaff@gmx.net
Mon Nov 10 15:41:00 GMT 2003


Christopher Faylor wrote:
> On Mon, Nov 10, 2003 at 10:09:52AM -0500, Christopher Faylor wrote:
> 
>>On Mon, Nov 10, 2003 at 03:03:06PM +0100, Thomas Pfaff wrote:
>>
>>>Christopher Faylor wrote:
>>>
>>>>On Mon, Nov 10, 2003 at 12:23:35PM +0100, Thomas Pfaff wrote:
>>>>
>>>>
>>>>>Attached patch fixes the memory leak reported by Arash Partow by
>>>>>initializing stdio during startup and setting __sdidinit from thread
>>>>>local clib appropriately.
>>>>>
>>>>>Thomas
>>>>>
>>>>>2003-11-10  Thomas Pfaff  <tpfaff@gmx.net>
>>>>>
>>>>>	* dcrt0.cc: Add prototype for __sinit.
>>>>>	(dll_crt0_1): Initialize stdio.
>>>>
>>>>
>>>>The above two things are already done in dcrt0.cc.  Why are you adding
>>>>additional prototypes and going to additional work?
>>>>
>>>
>>>Ouch. I should have stayed in bed today.
>>
>>But the rest of your patch looks ok, I think, doesn't it?
> 
> 
> Actually, on poking around a little, I wonder if we should be calling
> _reclaim_reent to get back all of the stuff allocated in the REENT
> structure?
> 

It might be better to call _reclaim_reent instead of 
(*_REENT->__cleanup) (_REENT).
I will check tommorow.

Thomas



More information about the Cygwin-patches mailing list