[Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

[Pierre A. Humblet]

Christopher Faylor wrote:
> 
> On Sun, Dec 07, 2003 at 10:24:31PM -0500, Pierre A. Humblet wrote:
> >It's mostly fine (rxvt and notty) but starting the following from DOS
> >creates a slew of warning from the handler protection code (below).
> >However the shell is functional.
> >tty reports /dev/tty, instead of /dev/ttyN with 1.5.5
> >
> >@echo off
> >set CYGWIN=tty
> >C:
> >chdir \progra~1\cygwin\bin
> >bash --login -i
> 
> This is odd, since this is specifically how I tested cygwin prior to checking
> everything in.  I can't duplicate this.
> 
> I initially couldn't duplicate the 'tty' problem either, but after my
> 15th clean rebuild, I did see it.  I don't know why I wasn't seeing it
> before.
> 
> I've checked in a fix for the ttyname and a shot in the dark for the
> mark_closed problems.

Thanks Chris, I will try that tonight.
Did you test with both CYGWIN=tty and --login?

Pierre