lstat symbolic link size

Christopher Faylor cgf-no-personal-reply-please@cygwin.com
Wed Jan 7 18:12:00 GMT 2004


On Wed, Jan 07, 2004 at 11:33:18AM -0600, Brian Ford wrote:
>On Mon, 5 Jan 2004, Christopher Faylor wrote:
>
>> On Mon, Jan 05, 2004 at 08:38:24PM -0500, Christopher Faylor wrote:
>> >On Tue, Jan 06, 2004 at 09:30:26AM +0800, peter garrone wrote:
>> >>lstat returns an incorrect symbolic link size, with size 11 bytes too large.
>> >>
>> >lstat reports the actual size of the symlink file.  Unless you can point
>> >to a standard which indicates this is incorrect, we'll be sticking with
>> >this long standing behavior.
>> >
>> Actually, nevermind.  SUSv3 says this:
>>
>> For symbolic links, the st_mode member shall contain meaningful
>> information when used with the file type macros, and the st_size member
>> shall contain the length of the pathname contained in the symbolic link.
>>
>> So, this is a PTC situation.
>>
>Ok, here it is.
>
>2004-01-07  Brian Ford  <ford@vss.fsi.com>
>
>	* fhandler_disk_file.cc (fhandler_base::fstat_helper): Comply with
>	SUSv3 for a symlink's st_size, ie. the length of the target
>	pathname.

Thanks but that is not the correct fix.  The target pathname is not the
windows path.

cgf

>Index: fhandler_disk_file.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/fhandler_disk_file.cc,v
>retrieving revision 1.75
>diff -u -p -r1.75 fhandler_disk_file.cc
>--- fhandler_disk_file.cc	15 Dec 2003 04:16:42 -0000	1.75
>+++ fhandler_disk_file.cc	7 Jan 2004 17:23:10 -0000
>@@ -291,6 +291,8 @@ fhandler_base::fstat_helper (struct __st
>     {
>       /* symlinks are everything for everyone! */
>       buf->st_mode = S_IFLNK | S_IRWXU | S_IRWXG | S_IRWXO;
>+      /* SUSv3: their size is the length of the target pathname */
>+      buf->st_size = strlen (pc.get_win32 ());
>       get_file_attribute (pc.has_acls (), get_win32_name (), NULL,
> 			  &buf->st_uid, &buf->st_gid);
>       goto done;



More information about the Cygwin-patches mailing list