FW: Final patch for audio recording with /dev/dsp
Wed Mar 3 14:14:00 GMT 2004
On Wed, Mar 03, 2004 at 10:55:43AM +0100, Corinna Vinschen wrote:
>[Sorry for the delay, I didn't realize that my mail to cygwin-patches
> didn't come through]
>thanks for the patch, but regardless of the content, it's not acceptable
>for a few stylistic reasons:
>- All sentences end in a full stop in the ChangeLog.
>- Could you please change all one line if expressions like this:
> if (head_ == depth1_) head_ = 0;
> if (head_ == depth1_)
> head_ = 0;
>- Please change `*(buffer+1)' to `*(buffer + 1)'.
Or better yet, in that case: buffer
More information about the Cygwin-patches