Patch 20040321 for audio recording with /dev/dsp (indented)

Corinna Vinschen vinschen@redhat.com
Mon Mar 22 17:05:00 GMT 2004


On Mar 21 22:55, Gerd Spalink wrote:
> There were no comments about the test program I sent. Do you want to
> put it or something like it into the repository?

I used your test application after applying the patch locally.

Some of the tests don't emit a sound, is that correct?

  $ ./devdsp
  Set bits=16 stereo=1 rate=44100 sync=0x00000000
  Buffer size=22080
  Formats=00000018

  [Beeping starts here]

  Set bits= 8 stereo=0 rate=44100 sync=0x00000000
  Set bits=16 stereo=0 rate=44100 sync=0x00000000
  Set bits= 8 stereo=1 rate=44100 sync=0x00000000
  Set bits=16 stereo=1 rate=44100 sync=0x00000000
  Set bits= 8 stereo=0 rate=22050 sync=0x00000000
  Set bits=16 stereo=0 rate=22050 sync=0x00000000
  Set bits= 8 stereo=1 rate=22050 sync=0x00000000
  Set bits=16 stereo=1 rate=22050 sync=0x00000000
  Set bits= 8 stereo=0 rate= 8000 sync=0x00000000
  Set bits=16 stereo=0 rate= 8000 sync=0x00000000
  Set bits= 8 stereo=1 rate= 8000 sync=0x00000000
  Set bits=16 stereo=1 rate= 8000 sync=0x00000000

  [From now on, the tests make *no* sound]

  Set bits= 8 stereo=0 rate=44100 sync=0x00000000
  Set bits=16 stereo=0 rate=44100 sync=0x00000000
  Set bits= 8 stereo=1 rate=44100 sync=0x00000000
  Set bits=16 stereo=1 rate=44100 sync=0x00000000
  Set bits= 8 stereo=0 rate=22050 sync=0x00000000
  Set bits=16 stereo=0 rate=22050 sync=0x00000000
  Set bits= 8 stereo=1 rate=22050 sync=0x00000000
  Set bits=16 stereo=1 rate=22050 sync=0x00000000
  Set bits= 8 stereo=0 rate= 8000 sync=0x00000000
  Set bits=16 stereo=0 rate= 8000 sync=0x00000000
  Set bits= 8 stereo=1 rate= 8000 sync=0x00000000
  Set bits=16 stereo=1 rate= 8000 sync=0x00000000
  Set bits=16 stereo=1 rate=44100 sync=0x00000000

  [And now the beeping starts again]

  forked, child PID=1812 parent records
  [...]

I'm not quite sure about putting the testcase into the testsuite.
It's a good idea in general, but, well, I'm wondering if you'd
like to use the libltp framework for the testresults, perhaps?

Btw., what happens if somebody without sound card and sound driver
starts the test?  Did you check that?

Other than that your latest patch looks pretty good, though there
are still a few formatting issues, e. g.

  if (foo &&
      bar

should be

  if (foo
      && bar)

in GNU coding style.  However, I'll apply it after 1.5.10 is out
and run indent on it, as soon as you can explain to me (as a sound
programming anaphylactic) why I can't hear a sound in the above
tests.

Since that code makes you to the one and only audio code maintainer
for Cygwin, I'm wondering if you're also interested in maintaining
some audio application which makes use of this new Cygwin code,
as part of the Cygwin net distribution...


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.



More information about the Cygwin-patches mailing list