[Patch] fhandler_disk_file::fchmod

Christopher Faylor cgf-no-personal-reply-please@cygwin.com
Sat Aug 21 15:37:00 GMT 2004


On Sat, Aug 21, 2004 at 05:08:18PM +0200, Corinna Vinschen wrote:
>On Aug 21 09:53, Christopher Faylor wrote:
>> On Sat, Aug 21, 2004 at 09:46:31AM -0400, Pierre A. Humblet wrote:
>> >This bug was found while investigating testsuite failures.  It occurs
>> >only on 9x, when ntsec is on.  An alternate (more general) solution
>> >would be to only set allow_ntsec (in environ.cc) on NT.  Why allow it
>> >on 9x?
>> 
>> That was my first reaction on looking at your patch before reading the
>> above comment.
>> 
>> Why don't we do that?  It seems like it would simplify things slightly
>> throughout cygwin.
>
>allow_ntsec is only set to true on NT by default.  The above problem can
>only occur if somebody explicitely sets CYGWIN=ntsec on a 9x system (sic).
>
>What about this:
>
>	* environ.cc (set_ntea): New function.
>	(set_ntsec): Ditto.
>	(set_smbntsec): Ditto.
>	(parse_thing): Change ntea, ntsec and smbntsec settings to call
>	appropriate functions.

Looks good.

cgf



More information about the Cygwin-patches mailing list