[Patch] Testing loads of cygwin1.dll from MinGW and MSVC, take 3

[Christopher Faylor]

On Mon, Jun 06, 2005 at 02:01:44PM -0700, Max Kaehn wrote:
>This patch contains a revised version of the "cygload" test utility,
>this time with even better adherence to cygwin naming and indentation.
>Igor, thanks for pointing me at "indent"-- it also pointed out
>that I was forgetting to put spaces in front of the parameter
>lists for my function calls.
>
>I'm using diff -upN against an empty directory "winsup/testsuite/cyglode";
>I hope that's OK.
>---
>ChangeLog for winsup/testsuite:
>
>2005-05-27  Max Kaehn <slothman@electric-cloud.com>
>
>	* Makefile.in:  now tests cygload.
>	* cygload:  New directory.
>	* cygload/README:  New file.
>	* cygload/Makefile:  Ditto.
>	* cygload/cygload.h:  Ditto.
>	* cygload/cygload.cc:  Ditto.
>	* cygload/cygload.exp:  Ditto.

There were still some braces at the end of the line in cygload.h so I
changed those.  I also changed the ChangeLog entry "now tests cygload"
to "Test cygload".  See http://cygwin.com/contrib.html for some common
mistakes in ChangeLog entries.

So, I checked in the above and, after changing cygload.exp so that it
compiles cygload.cc rather than cygload.cpp, I found a more serious
error.  I've attached the cygload.log file.  It doesn't look pretty,
unfortunately.  You might notice the same thing if you configure your
Cygwin DLL with --enable-debugging, like I do.

Another problem is that since you have separated out the Makefile into
two separate invocations of $(RUNTEST) the error return from the Makefile
will not be set correctly.  To preserve previous operation, the makefile
should do all of the tests and then return with a status of zero if things
completed correctly or nonzero otherwise.

cgf
-------------- next part --------------
Opening log files in .
Test Run By cgf on Mon Jun  6 17:27:17 2005
Native configuration is i686-pc-cygwin

		=== cygload tests ===

setting trap for SIGTERM to terminated
setting trap for SIGINT to interrupted by user
setting trap for SIGQUIT to interrupted by user
setting trap for SIGSEGV to segmentation violation
dirlist is /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/baseboards
pushing config for build, name is norton
dirlist is /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/baseboards
pushing config for host, name is norton
Schedule of variations:
    unix

target is unix
Running target unix
dirlist is /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/baseboards/norton /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/baseboards
Using /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/baseboards/unix.exp as board description file for target.
Using /cygnus/src/uberbaum/winsup/testsuite/../../dejagnu/config/unix.exp as generic interface file for target.
Using /cygnus/src/uberbaum/winsup/testsuite/config/default.exp as tool-and-target-specific interface file.
pushing config for target, name is unix
Running /cygnus/src/uberbaum/winsup/testsuite/cygload/cygload.exp ...
running gcc -mno-cygwin /cygnus/src/uberbaum/winsup/testsuite/cygload/cygload.cc -o mingw-cygload.exe -lstdc++ -Wl,-e,_cygloadCRTStartup@0

running ./mingw-cygload.exe -cygwin j:/build/i686-pc-cygwin/winsup/cygwin/cygwin0.dll > ./mingw-cygwin.log

cygload: 1 {      3 [main] ? 1992 add_handle: void memory_init():257 - multiple attempts to add handle cygheap->shared_h<0x774>
  79191 [main] ? 1992 add_handle:  previously allocated by gned int shared_info::heap_chunk_size():257(_chunk_size()<0x774>) winpid 2600
  86782 [main] ? 1992 add_handle: void user_shared_initialize(bool):185 - multiple attempts to add handle cygwin_user_h<0x768>
  95160 [main] ? 1992 add_handle:  previously allocated by :185(????qa??<0x768>) winpid 2600
 112620 [main] ? 1992 add_handle: void mtinfo_init():1176 - multiple attempts to add handle cygheap->mt_h<0x76C>
 128555 [main] ? 1992 add_handle:  previously allocated by a????????:1176(??D$??????a??$????a????????????????a??????$??????????????,??????????????????????????????????????????????????fhandler_dev_tape::fhandler_dev_tape()<0x76C>) winpid 2600}
FAIL: cygload (execute)
testcase /cygnus/src/uberbaum/winsup/testsuite/cygload/cygload.exp completed in 6 seconds

		=== cygload Summary ===

# of unexpected failures	1
runtest completed at Mon Jun  6 17:27:23 2005