[PATCH] cygcheck: follow symbolic links
Corinna Vinschen
corinna-cygwin@cygwin.com
Thu Feb 16 16:06:00 GMT 2006
On Feb 13 13:44, Igor Peshansky wrote:
> As promised in <http://cygwin.com/ml/cygwin/2006-02/msg00071.html>, the
> attached patch teaches cygcheck to follow symlinks when looking for
> executables, and also flags scripts. Sorry, had legal delays in sending
> this (as you can see, I had this working since 02/03). Comments welcome.
> Igor
A few comments.
- Most of your patch should go into path.cc so it can be reused, for
instance in strace.
- Your readlink lacks checking the file attributes. Shortcut symlinks
require a R/O attribute to be valid, old-style symlinks require the
SYSTEM attribute.
- Couldn't you just reuse the readlink implementation in ../cygwin/path.cc
as is, to avoid having to different implementations?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
More information about the Cygwin-patches
mailing list