[PATCH] cygcheck: follow symbolic links
Fri Feb 17 14:06:00 GMT 2006
On Fri, 17 Feb 2006, Corinna Vinschen wrote:
> On Feb 16 12:26, Igor Peshansky wrote:
> > On Thu, 16 Feb 2006, Corinna Vinschen wrote:
> > > - Most of your patch should go into path.cc so it can be reused, for
> > > instance in strace.
> > Agreed -- that's why I put that TODO in there. :-) Should I move it in
> > the next iteration of the patch?
> Please move it now. I don't think it's non-trivial enough to justify
> multiple iterations.
Whoops. Misspoke. I meant "incarnation". Never mind, I'll just do it.
:-) Expect a new patch today.
> > > - Couldn't you just reuse the readlink implementation in
> > > ../cygwin/path.cc as is, to avoid having to different
> > > implementations?
> > Umm, most of that code is very general purpose, and has too much extra
> > stuff in it. I basically used part of it (symlink_info::check_shortcut)
> > for my implementation. I wanted something lightweight and easy to
> > understand (also, the code in path.cc doesn't check for PE headers, so I
> > had to write that part anyway).
> Well, what I meant isn't readlink but symlink_info::check_shortcut and
> cmp_shortcut_header. It would be helpful if the rules to identify a
> symlink are identical, wouldn't it? As for the PE headers, that's fine.
It would certainly help, but then we would need to extract the bit of code
that deals with symlinks and put it in a Cygwin-independent static
library. See my reply to Dave.
|\ _,,,---,,_ firstname.lastname@example.org | email@example.com
ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
More information about the Cygwin-patches