fhandler_base::readv

Lev Bishop lev.bishop@gmail.com
Wed May 24 02:23:00 GMT 2006


On 5/23/06, Lev Bishop wrote:

> It does make sense. Try this version.

Sorry, no. I'm stupid - ignore that version. There's not much point in
doing assert(len>=0) given that len is unsigned, it's pretty much a
given :-) How about just removing the assert()?

So here's the 3rd attempt.

2006-05-23  Lev Bishop  <lev.bishop+cygwin@gmail.com>

	* fhandler.cc (readv): Deal with tot not precalculated.
-------------- next part --------------
Index: fhandler.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/fhandler.cc,v
retrieving revision 1.251
diff -u -p -r1.251 fhandler.cc
--- fhandler.cc	22 Mar 2006 16:42:44 -0000	1.251
+++ fhandler.cc	24 May 2006 02:22:10 -0000
@@ -966,8 +966,6 @@ fhandler_base::readv (const struct iovec
       while (iovptr != iov);
     }
 
-  assert (tot >= 0);
-
   if (!len)
     return 0;
 


More information about the Cygwin-patches mailing list