Wed Jul 26 23:20:00 GMT 2006
On Wed, Jul 26, 2006 at 05:53:35PM -0500, Brian Ford wrote:
>I think this removes some redundancy and a questionable check while being
>more straight forward and covering more possible fault cases. Please let
>me know if I missed a reason it had to be that way.
>2006-07-26 Brian Ford <Brian.Ford@FlightSafety.com>
> * miscfuncs.cc (dummytest): Delete.
Thanks for the patch, but I'm not convinced that this patch duplicates
the functionality that you eliminated from check_iovec.
It is not "more straighforward" to move a check out of a function and
duplicate it in callers of the function. And, the dummytest is actually
there for a reason. Unless you can give more of a rationale for your
changes they will not be applied.
More information about the Cygwin-patches