[Patch] bug # 514 deja vu (cygwin console color handling)
Thu Nov 23 10:09:00 GMT 2006
On Nov 22 18:20, Thomas Wolff wrote:
> I noticed that the reverse color bug
> shows up again in recent cygwin1.dll updates. My previous patch
> is still in the source but additional code apparently has the same
> effect of rendering output unreadable; the effect is the following:
> * foreground is set bright
> * screen mode is set to reverse
> * cygwin wrongly assumes that the reverse foreground colour (which
> actually used to be the non-bright background color) should be
> set to bright, which is obviously a wrong idea and often results
> in a contrast that renders the output almost unreadable
> The attached shell script test514 demonstrates the bug.
> The attached patch is an attempt to fix the bug again.
> * fhandler_console.cc (set_color): Avoid (again) inappropriate intensity
> interchanging that used to render reverse output unreadable
> when (non-reversed) text is bright.
> See http://sourceware.org/bugzilla/show_bug.cgi?id=514
Yup, that seems to do the trick. Thanks, applied.
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
More information about the Cygwin-patches